Conversation
|
Is this PR correct and is it going to be accepted into ecc/PyECC here? |
|
@blackbeam could you provide more information and context for your change, so we can review it? |
|
Output of this implementation is correct and tests proved it. But without this PR this implementation will generate: It is both incompatible and insecure. But as i can see now this PR is incomplete. Same issue is in I will fix this as soon as i get some spare time. |
|
Done. |
|
I am not qualified enough to see through this change. @amintos would be, I guess. I also found this implementation in Java with some tests and this Javascript implementation which has a file called verified test vectors. That should be part of tests so we can see which implementation is correct. |
No description provided.